[webkit-reviews] review granted: [Bug 14951] REGRESSION: page interpreted as UTF-8 because of stray <?xml> after <head> : [Attachment 15954] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 12:42:10 PDT 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 14951: REGRESSION: page interpreted as UTF-8 because of stray <?xml> after
<head>
http://bugs.webkit.org/show_bug.cgi?id=14951

Attachment 15954: proposed fix
http://bugs.webkit.org/attachment.cgi?id=15954&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    // Is there enough data available to check for XML declaration?
+    if (m_buffer.size() < 8)
+	 return false;

Why not put that check before setting up ptr and pEnd?

r=me



More information about the webkit-reviews mailing list