[webkit-reviews] review granted: [Bug 14635] Uploading file with non-ASCII character in path fails : [Attachment 15934] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 11:39:27 PDT 2007


Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 14635: Uploading file with non-ASCII character in path fails
http://bugs.webkit.org/show_bug.cgi?id=14635

Attachment 15934: updated patch
http://bugs.webkit.org/attachment.cgi?id=15934&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+    return String(PathFindFileName(path.charactersWithNullTermination()));

Do you need the explicit String() here? Doesn't the conversion happen
automatically?

Also, we often use "filename" as a single word; so I think the variables and
functions could just be all lowercase.

r=me



More information about the webkit-reviews mailing list