[webkit-reviews] review denied: [Bug 14935] ResourceLoader should call ResourceHandle::setClient(0) after checking it's still the ResourceHandle's client : [Attachment 15914] Verify we're still the ResourceHandle's client before clearing it out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 11 15:26:19 PDT 2007


Darin Adler <darin at apple.com> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 14935: ResourceLoader should call ResourceHandle::setClient(0) after
checking it's still the ResourceHandle's client
http://bugs.webkit.org/show_bug.cgi?id=14935

Attachment 15914: Verify we're still the ResourceHandle's client before
clearing it out
http://bugs.webkit.org/attachment.cgi?id=15914&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I don't think there's any reason to make this code change. It's only needed if
ResourceLoader shares a ResourceHandle with another client. That's never done,
so we don't need the code.

Unless there's something I'm missing and this actually happens.



More information about the webkit-reviews mailing list