[webkit-reviews] review denied: [Bug 14635] Uploading file with non-ASCII character in path fails : [Attachment 15933] proposed fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 11 12:54:17 PDT 2007


Adam Roben <aroben at apple.com> has denied Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 14635: Uploading file with non-ASCII character in path fails
http://bugs.webkit.org/show_bug.cgi?id=14635

Attachment 15933: proposed fix
http://bugs.webkit.org/attachment.cgi?id=15933&action=edit

------- Additional Comments from Adam Roben <aroben at apple.com>
+static String pathGetFileName(const String& path)
+{
+#if PLATFORM(WIN_OS)
+    return String(PathFindFileName(path.charactersWithNullTermination()));

This won't compile, since charactersWithNullTermination is a non-const instance
method.



More information about the webkit-reviews mailing list