[webkit-reviews] review granted: [Bug 14740] Hierarchical layout tests and platform organization : [Attachment 15930] reviewable v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 11 12:37:37 PDT 2007

Adam Roben <aroben at apple.com> has granted Matt Lilek <pewtermoose at gmail.com>'s
request for review:
Bug 14740: Hierarchical layout tests and platform organization

Attachment 15930: reviewable v3

------- Additional Comments from Adam Roben <aroben at apple.com>
+    mkpath($platformTestDirectory) if ($platform eq "undefined" && !-d

This behavior seems fine, though it will be a little less confusing for people
if you print out a message along the lines of "Your platform is not recognized.
Any new results will be generated in platform/undefined." Or you could just
abort the script with a call to die.

Either way, r=me (again :-)

More information about the webkit-reviews mailing list