[webkit-reviews] review granted: [Bug 14740] Hierarchical layout tests and platform organization : [Attachment 15925] reviewable v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 23:33:13 PDT 2007

Adam Roben <aroben at apple.com> has granted Matt Lilek <pewtermoose at gmail.com>'s
request for review:
Bug 14740: Hierarchical layout tests and platform organization

Attachment 15925: reviewable v2

------- Additional Comments from Adam Roben <aroben at apple.com>
+    # FIXME: Get rid of the $useWinSkipped hack once Windows doesn't need a
Skipped file anymore
+    # or stops using the mac result directory or we come up with something

I think this should say something clearer like:

# FIXME: The two lines below are a hack to represent that on Windows we
# currently want to
# 1) use the Mac expected results
# 2) use the Windows Skipped file
# Once Windows has its own results and/or we come up with a better way of
# sharing results with Mac, we should set $platform to "win" and get rid of
# $useWinSkipped entirely.

+	     print "new (result generated in $expectedDir)\n";

I think it should be "results" with an "s".

+    if (!defined($platform) || $platform eq "none") {
+	 return $testDirectory;
+    }

I think you'd better return ($testDirectory) so that the caller still gets a


More information about the webkit-reviews mailing list