[webkit-reviews] review granted: [Bug 14740] Hierarchical layout
tests and platform organization : [Attachment 15915] reviewable v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 10 19:18:41 PDT 2007
Adam Roben <aroben at apple.com> has granted Matt Lilek <pewtermoose at gmail.com>'s
request for review:
Bug 14740: Hierarchical layout tests and platform organization
http://bugs.webkit.org/show_bug.cgi?id=14740
Attachment 15915: reviewable v1
http://bugs.webkit.org/attachment.cgi?id=15915&action=edit
------- Additional Comments from Adam Roben <aroben at apple.com>
+my $platformDefault = $platform ? $platform : "none";
I wonder if we should die if $platform is undefined at this point. Seems like
bad things might happen down the road if we keep going.
+ my $resultDir = expectedDirectoryForTest($test);
I think you can just use $expectedDir instead (this happens in 2 places).
r=me!
More information about the webkit-reviews
mailing list