[webkit-reviews] review requested: [Bug 13670] Table misrender when one of the TDs has width=100% : [Attachment 15906] Change the cap from 99% to >99.99%

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 10 07:09:45 PDT 2007


mitz at webkit.org has asked  for review:
Bug 13670: Table misrender when one of the TDs has width=100%
http://bugs.webkit.org/show_bug.cgi?id=13670

Attachment 15906: Change the cap from 99% to >99.99%
http://bugs.webkit.org/attachment.cgi?id=15906&action=edit

------- Additional Comments from mitz at webkit.org
The patch also removes the "+ 50" which has been in the code since
<http://trac.webkit.org/projects/webkit/changeset/3351>. This fixes a bug that
has become even more apparent by raising the cap from 99% closer to 100%, and
causes no regressions. I've included a test for the bug, where the new results
match WinIE.

I have a version that tests directly for the "0%" cases and uses INT_MAX as max
width in those cases. It gives the same results in testing, but I think using
INT_MAX is still a hack, and is perhaps more risky than this patch's approach.



More information about the webkit-reviews mailing list