[webkit-reviews] review granted: [Bug 13909] SVG text selection doesn't work with RTL text : [Attachment 15858] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 7 15:49:53 PDT 2007


Oliver Hunt <oliver at apple.com> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 13909: SVG text selection doesn't work with RTL text
http://bugs.webkit.org/show_bug.cgi?id=13909

Attachment 15858: Initial patch
http://bugs.webkit.org/attachment.cgi?id=15858&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I would prefer it if 
int offset = !textBox->m_reversed ? textBox->start() + i : textBox->end() - i;

was instead
int offset = textBox->m_reversed ? textBox->end() - i : textBox->start() + i;



More information about the webkit-reviews mailing list