[webkit-reviews] review denied: [Bug 6129] Incomplete implementation of CSS 2.1 system colors : [Attachment 15614] First attempt

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 6129: Incomplete implementation of CSS 2.1 system colors
http://bugs.webkit.org/show_bug.cgi?id=6129

Attachment 15614: First attempt
http://bugs.webkit.org/attachment.cgi?id=15614&action=edit

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I think it's possible to override the system highlight colours via a user
default, so we should be able to force DRT to run with a consistent colour on
all machines.

As Darin mentioned, some of the Carbon APIs that you have used are not
available for 64-bit.  It would be great to see an updated version of this
patching using the equivalent Cocoa APIs, even it does take a little more code.