[webkit-reviews] review requested: [Bug 13422] REGRESSION: Page reload loses page position : [Attachment 15846] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 6 01:10:54 PDT 2007

Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has asked  for review:
Bug 13422: REGRESSION: Page reload loses page position

Attachment 15846: Proposed patch

------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Here is a patch that fixes the bug. In revision 17365, many Objective C method
bodies in WebFrame were moved to the C++ wrapper class WebFrameLoaderClient for
performance reasons. However, in copying the updateHistoryForReload() method, a
small error was introduced. In the original method, currItem is made the
current history item of the frame:

WebHistoryItem *currItem = _private->currentItem;

In the copied version, this is changed to

WebHistoryItem *currItem = m_webFrame->_private->previousItem;

This patch corrects that change, which was carried over into the new loader

More information about the webkit-reviews mailing list