[webkit-reviews] review requested: [Bug 14742] Document::recalcStyle(Force) called for every updateStyleIgnorePendingStylesheets while waiting for stylesheets : [Attachment 15818] Patch (for now)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 3 08:07:05 PDT 2007


mitz at webkit.org has asked  for review:
Bug 14742: Document::recalcStyle(Force) called for every
updateStyleIgnorePendingStylesheets while waiting for stylesheets
http://bugs.webkit.org/show_bug.cgi?id=14742

Attachment 15818: Patch (for now)
http://bugs.webkit.org/attachment.cgi?id=15818&action=edit

------- Additional Comments from mitz at webkit.org
This is a very pinpointed and conservative fix.

I think in the long run, Document::updateStyleSelector() should be replaced
with a function that just sets a "style selector dirty" flag, and
Document::styleSelector() should lazily update the style selector as needed.
That is worth doing even if JavaScript becomes interruptible, because it will
coalesce style updates.



More information about the webkit-reviews mailing list