[webkit-reviews] review denied: [Bug 12878] Support for each (var in collection) syntax : [Attachment 15782] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 1 10:25:05 PDT 2007

Mark Rowe (bdash) <mrowe at apple.com> has denied Justin Haygood
<jhaygood at spsu.edu>'s request for review:
Bug 12878: Support for each (var in collection) syntax

Attachment 15782: Updated Patch

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I pointed out a few issues in the patch to Justin via IRC.  There are numerous
coding style inconsistencies, and the redeclaration of ForInNode's instance
variables in the subclass is wrong.  I also suggested that the implementation
of streamTo could easily be shared between the two classes which should allow
ForInNode's members to remain private.

More information about the webkit-reviews mailing list