[webkit-reviews] review granted: [Bug 12501] SVG Text fails to respect opacity, fill-opacity and stroke-opacity : [Attachment 14274] First attempt

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 12501: SVG Text fails to respect opacity, fill-opacity and stroke-opacity
http://bugs.webkit.org/show_bug.cgi?id=12501

Attachment 14274: First  attempt
http://bugs.webkit.org/attachment.cgi?id=14274&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'd almost prefer a declaration

CGFloat opacity = style->svgStyle()->strokeOpacity();
colorComponents[3] = opacity;
....
Color(float(colorComponents[0]) * 255., float(colorComponents[1]) * 255.,
float(colorComponents[2]) * 255., float(opacity) * 255.0f)

I think it makes it more clear that you're deliberately ignoring the alpha
channel specified by the style.

Also you have float(colorComponents[3] * 255.) which should be
float(colorComponents[3]) * 255. to match the other cases

255. should be 255.0f to prevent any dumb usages of double

otherwise r=me