[webkit-reviews] review denied: [Bug 13487] Implement O(1) absoluteClippedOverflowRect and absoluteOutlineBox during layout for a possible speed gain : [Attachment 14236] Keep track of absolute translation and clip during layout

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 27 14:22:57 PDT 2007


Dave Hyatt <hyatt at apple.com> has denied mitz at webkit.org's request for review:
Bug 13487: Implement O(1) absoluteClippedOverflowRect and absoluteOutlineBox
during layout for a possible speed gain
http://bugs.webkit.org/show_bug.cgi?id=13487

Attachment 14236: Keep track of absolute translation and clip during layout
http://bugs.webkit.org/attachment.cgi?id=14236&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't think you need to add  the boxLayer() method.  The cost of layer() is
completely negligible if you get the O(n^2) stuff out of the way.

I know it looks like it mattered because I added that hasLayer() stuff
recently, but it was really only showing up because it was being called a
ludicrous number of times (and even then it was only like 1%).



More information about the webkit-reviews mailing list