[webkit-reviews] review denied: [Bug 13478] RenderObject::absoluteBoundingBoxRect() should ignore rects outside the bounds of the document : [Attachment 14219] Patch v3

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 13478: RenderObject::absoluteBoundingBoxRect() should ignore rects outside
the bounds of the document
http://bugs.webkit.org/show_bug.cgi?id=13478

Attachment 14219: Patch v3
http://bugs.webkit.org/attachment.cgi?id=14219&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
So you have really opened up a can of worms with this patch.

I don't think this is the right spot to deal with this problem looking into
this more.  There are several other callers of absoluteRects, and they are all
wrong too.

absoluteRects shouldn't even be handing back these unreachable rects in the
first place, so patching in absoluteBoundingBoxRect is dealing with the problem
too late.

WebCoreAXObject.mm calls absoluteRects for example (and so suffers from the
same bug), and HTMLAnchorElement.cpp does as well.

I think you basically need to patch absoluteRects to intersect the rects with
the document bounds.  There is no logical reason to ever be handing these
completely unreachable rects back.