[webkit-reviews] review requested: [Bug 13415] Add UTF-32 support for html/xml documents : [Attachment 14218] patch with test cases and changelog entries

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 26 17:37:43 PDT 2007


Jungshik Shin <jungshik.shin at gmail.com> has asked  for review:
Bug 13415: Add UTF-32 support for html/xml documents
http://bugs.webkit.org/show_bug.cgi?id=13415

Attachment 14218: patch with test cases and changelog entries
http://bugs.webkit.org/attachment.cgi?id=14218&action=edit

------- Additional Comments from Jungshik Shin <jungshik.shin at gmail.com>
Added test cases for UTF-32BE (html  with BOM and xml without BOM) and UTF-32LE
(html with BOM and xml without BOM).  I can't make a xml test case for UTF-32LE
that prints out document.inputEncoding.  I tried document.write() and a few
DOM-based methods to add a node, "<p>{the value of
document.inputEncoding}</p>", but I couldn't make it work in Safari. 

For UTF-32BE, just comparing the output (without document.inputEncoding) is
sufficient because it cannot be mistaken for UTF-16BE or other encodings. For
UTF-32LE, we'd better print out the value of document.inputEncoding.



More information about the webkit-reviews mailing list