[webkit-reviews] review requested: [Bug 12327] Windows build bustage + vcproj/sln craziness : [Attachment 14191] Complete patch for r21100

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 16:43:32 PDT 2007

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 12327: Windows build bustage + vcproj/sln craziness

Attachment 14191: Complete patch for r21100

------- Additional Comments from Peter Kasting <pkasting at google.com>
This does everything needed to get the Windows port building again in debug and
release modes: updates dependencies, includes all necessary .sln and .vcproj
changes, fixes all compile and link errors.

I hope this patch will be easier to review than Don's last patch.  I didn't
bother to fix any warnings and tried to limit my changes as much as possible to
Windows-specific files or code, so this should be a near-rubber-stamp.

I did have to fix one error introduced in r21090, where the compiler could not
determine which version of abs() to call (multiple overloads matched equally
well).	Presumably on the Mac this is unambiguous for some reason.

More information about the webkit-reviews mailing list