[webkit-reviews] review granted: [Bug 13431] calcMinMaxWidth should be lazy. : [Attachment 14170] more reduced patch, passes layout tests (code 99% by Hyatt, not me)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 12:01:38 PDT 2007


Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 13431: calcMinMaxWidth should be lazy.
http://bugs.webkit.org/show_bug.cgi?id=13431

Attachment 14170: more reduced patch, passes layout tests (code 99% by Hyatt,
not me)
http://bugs.webkit.org/attachment.cgi?id=14170&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Comments from our review:

Need to leave updateFirstLetter virtual (so we should dump RenderBlock.h).

Also should remove the mutable.

r=me



More information about the webkit-reviews mailing list