[webkit-reviews] review denied: [Bug 13312] portable implementation of <canvas> element : [Attachment 13993] patch.txt and a new platform header PlatformGraphics.h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 05:40:17 PDT 2007

Mark Rowe (bdash) <bdash at webkit.org> has denied 's request for review:
Bug 13312: portable implementation of <canvas> element

Attachment 13993: patch.txt and a new platform header PlatformGraphics.h

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
The big issue here is the addition of many new methods to GraphicsContext with
no implementations.  This will break all non-CoreGraphics builds, and at the
very least these should be stubbed out.  A ChangeLog entry and the necessary
project file changes would also be great.

Besides that there are some minor code style issues I noticed while skimming
the patch: the local variable "pg" in CanvasGradient::platformGradient seems
unnecessary and the placement of braces is incorrect, the declaration of
"count" has been manually lined up with "data", one of the changes in
HTMLCanvasElement.cpp adds unnecessary braces.

More information about the webkit-reviews mailing list