[webkit-reviews] review granted: [Bug 13445] NodeList access by index is slow : [Attachment 14161] easy way out

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13445: NodeList access by index is slow
http://bugs.webkit.org/show_bug.cgi?id=13445

Attachment 14161: easy way out
http://bugs.webkit.org/attachment.cgi?id=14161&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	 unsigned dist = (unsigned)abs((long)index -
(long)m_caches->lastItemOffset);

Since the parameter to abs is an int, the cast here should be to int, not long.
But also no casts are needed. If you do unsigned - unsigned, then pass to int,
and then extract it into unsigned it will do the right thing with no casts at
all.

Otherwise looks fine. r=me