[webkit-reviews] review granted: [Bug 13445] NodeList access by index is slow : [Attachment 14161] easy way out

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 25 01:04:25 PDT 2007

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 13445: NodeList access by index is slow

Attachment 14161: easy way out

------- Additional Comments from Darin Adler <darin at apple.com>
+	 unsigned dist = (unsigned)abs((long)index -

Since the parameter to abs is an int, the cast here should be to int, not long.
But also no casts are needed. If you do unsigned - unsigned, then pass to int,
and then extract it into unsigned it will do the right thing with no casts at

Otherwise looks fine. r=me

More information about the webkit-reviews mailing list