[webkit-reviews] review requested: [Bug 13478] RenderObject::absoluteBoundingBoxRect() should ignore rects outside the bounds of the document : [Attachment 14167] Patch v1 (feedback only!)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 24 22:04:01 PDT 2007


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 13478: RenderObject::absoluteBoundingBoxRect() should ignore rects outside
the bounds of the document
http://bugs.webkit.org/show_bug.cgi?id=13478

Attachment 14167: Patch v1 (feedback only!)
http://bugs.webkit.org/attachment.cgi?id=14167&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Looking for feedback on this patch.

- Am I getting the correct document bounds using windowClipRect(false)?
- Why do I have to "flip" the Y coordinate to make this work?



More information about the webkit-reviews mailing list