[webkit-reviews] review cancelled: [Bug 13471] REGRESSION (r21045): Secure keyboard entry mode remains in effect after leaving a password field by submitting : [Attachment 14157] Reset secure keyboard entry mode in Frame::setView

[bugzilla-daemon at webkit.org]

mitz at webkit.org has cancelled 's request for review:
Bug 13471: REGRESSION (r21045): Secure keyboard entry mode remains in effect
after leaving a password field by submitting
http://bugs.webkit.org/show_bug.cgi?id=13471

Attachment 14157: Reset secure keyboard entry mode in Frame::setView
http://bugs.webkit.org/attachment.cgi?id=14157&action=edit

------- Additional Comments from mitz at webkit.org
(In reply to comment #3)
> (From update of attachment 14157 [edit])
> Why not spell it "submit" everywhere?

Why not say "you made a typo"? ;-)

> What's the key reason this needs to be called? Is it really the change in
view
> that's the issue? Doesn't the input element lose focus?

In many senses, it never does (so I think that even prior to r21045, if you
happened to be in a secure text field when the new page was loaded, you'd
remain in Roman-only mode). The Frame doesn't keep track of focus, it just
serves requests from nodes to switch secure mode on or off. Presumably, those
nodes are in the Frame's Document. So now I'm thinking it may be more
appropriate to patch setDocument() instead of setView(). It would still just
reset to false unconditionally, since it can't (and doesn't need to) ask the
new document's focused node if it requires secure keyboard entry. However, that
could be changed in the future (if password fields can go into the page cache).