[webkit-reviews] review denied: [Bug 13442] Yahoo.com does not render properly in GDK port : [Attachment 14132] patch for adding correct User Agent String.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 21 19:35:41 PDT 2007


Mark Rowe (bdash) <bdash at webkit.org> has denied 's request for review:
Bug 13442: Yahoo.com does not render properly in GDK port
http://bugs.webkit.org/show_bug.cgi?id=13442

Attachment 14132: patch for adding correct User Agent String.
http://bugs.webkit.org/attachment.cgi?id=14132&action=edit

------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
You have a setter method which ignores its argument and uses a constant string.
 You then never use the member variable which is set, instead adding another
constant string.  You are also missing a ChangeLog entry.



More information about the webkit-reviews mailing list