[webkit-reviews] review requested: [Bug 13115] REGRESSION: 1000% performance regression in DOM access by index, which was already slow : [Attachment 14124] proposed fix

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 13115: REGRESSION: 1000% performance regression in DOM access by index,
which was already slow
http://bugs.webkit.org/show_bug.cgi?id=13115

Attachment 14124: proposed fix
http://bugs.webkit.org/attachment.cgi?id=14124&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
(In reply to comment #9)
> Also, if this struct is giong to be a member of the NodeList
> class, then its class name can just be Caches.

  OK.

> We normally don't do else after return.

  Fixed. I didn't really touch this code - only used global replace for Cache
members.

> Why are we retaining the old ChildNodeList constructor that does not take the

> pointer to the caches? I don't see any reason to do so.

  Just an oversight; removed.