[webkit-reviews] review denied: [Bug 13432]
determineSpacingForFlowBoxes is O(n^2) : [Attachment 14121]
Avoid edge testing if there's no need.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 21 05:59:57 PDT 2007
mitz at webkit.org has denied Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 13432: determineSpacingForFlowBoxes is O(n^2)
http://bugs.webkit.org/show_bug.cgi?id=13432
Attachment 14121: Avoid edge testing if there's no need.
http://bugs.webkit.org/attachment.cgi?id=14121&action=edit
------- Additional Comments from mitz at webkit.org
Actually, even testing each side separately isn't enough. It will fix
<span style="border-left: 5px solid; margin-right: -5px;">foo</span>
which is the example I had in mind for comment #3, but not
<span style="border-left: 5px solid; margin-left: -5px;">foo</span>
I think the setEdges(false, false) is unnecessary.
More information about the webkit-reviews
mailing list