[webkit-reviews] review granted: [Bug 13353] REGRESSION (r20754-20766): Textarea does not resize when scrollbar is present : [Attachment 14111] Fix overflow controls hit testing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 20 10:01:37 PDT 2007


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 13353: REGRESSION (r20754-20766): Textarea does not resize when scrollbar
is present
http://bugs.webkit.org/show_bug.cgi?id=13353

Attachment 14111: Fix overflow controls hit testing
http://bugs.webkit.org/attachment.cgi?id=14111&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Possible future improvement:

+	 IntRect vBarRect(absBounds.right() - renderer()->borderRight() -
m_vBar->width(), absBounds.y() + renderer()->borderTop(), m_vBar->width(),
absBounds.height() - (renderer()->borderTop() + renderer()->borderBottom()) -
(m_hBar ? m_hBar->height() : resizeControlSize));

This line is very long. Maybe use some additional local variables or a helper
function. Same with h-bar.

r=me



More information about the webkit-reviews mailing list