[webkit-reviews] review granted: [Bug 13407] [GDK] Fix font support
in Gdk port : [Attachment 14092] Fix page-specified fonts in
gdk port
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 20 00:07:40 PDT 2007
Mark Rowe (bdash) <bdash at webkit.org> has granted Alp Toker <alp at atoker.com>'s
request for review:
Bug 13407: [GDK] Fix font support in Gdk port
http://bugs.webkit.org/show_bug.cgi?id=13407
Attachment 14092: Fix page-specified fonts in gdk port
http://bugs.webkit.org/attachment.cgi?id=14092&action=edit
------- Additional Comments from Mark Rowe (bdash) <bdash at webkit.org>
Keep in mind that we prefer C++-style casts over the C-style casts. It looks
like the "assert" on "pattern" will only detect an out-of-memory condition,
which is a runtime error and as such not appropriate for an assertion.
r=me, I'll address those two nits when I land the change.
More information about the webkit-reviews
mailing list