[webkit-reviews] review denied: [Bug 13389] [js-collector-tweaks] move mark and collectOnMainThreadOnly bits into separate bitmaps : [Attachment 14070] 09-js-gc-mark-bitmap+32byte-cell.patch.txt

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 13389: [js-collector-tweaks] move mark and collectOnMainThreadOnly bits
into separate bitmaps
http://bugs.webkit.org/show_bug.cgi?id=13389

Attachment 14070: 09-js-gc-mark-bitmap+32byte-cell.patch.txt
http://bugs.webkit.org/attachment.cgi?id=14070&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+#include <sys/mman.h>

I don't think it's right that have this outside an #if -- is it really a header
that exists on all JavaScriptCore platforms.

Now that all these constants have to be moved into a header file, maybe we
should make them have non-all-capitals name or use a namespace or something.
They're pretty ugly.