[webkit-reviews] review granted: [Bug 13384] [js-collector-tweaks] Shrink PropertyMap by 8 bytes : [Attachment 14065] 04-js-gc-shrink-propertymap.patch.txt

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 13384: [js-collector-tweaks] Shrink PropertyMap by 8 bytes
http://bugs.webkit.org/show_bug.cgi?id=13384

Attachment 14065: 04-js-gc-shrink-propertymap.patch.txt
http://bugs.webkit.org/attachment.cgi?id=14065&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
We should just get rid of m_singleEntryAttributes and allow single entries only
when attributes are 0. But that won't save any size.

-inline PropertyMap::PropertyMap() : _table(0)
+inline PropertyMap::PropertyMap() 
+  : m_singleEntryKey(0)
+  , m_getterSetterFlag(false)
+  , m_usingTable(false)
+
 {
-    _singleEntry.globalGetterSetterFlag = 0;
+  m_u.table = 0;
 }

Should be 4-character indented.

Why are we initializing m_u.table?

Otherwise looks good. I read the whole thing.