[webkit-reviews] review granted: [Bug 13303] REGRESSION: controls in a background Safari window maintain active appearance if the address bar has focus : [Attachment 14046] patch that updates the tint based on the appropriate AppKit method

[bugzilla-daemon at webkit.org]

John Sullivan <sullivan at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 13303: REGRESSION: controls in a background Safari window maintain active
appearance if the address bar has focus
http://bugs.webkit.org/show_bug.cgi?id=13303

Attachment 14046: patch that updates the tint based on the appropriate AppKit
method
http://bugs.webkit.org/attachment.cgi?id=14046&action=edit

------- Additional Comments from John Sullivan <sullivan at apple.com>
I think the names "setSecureKeyboardEntry()" and
"setNeedsSecureKeyboardEntry()" are confusingly similar.

Also, you probably realize that you could learn of changes to the window's key
state by listening to NSWindowDidBecomeKey/NSWindowDidResignKey rather than
using _windowChangedKeyState. I presume you chose _windowChangedKeystate for
simplicity/performance. Maybe worth a comment.

r=me