[webkit-reviews] review requested: [Bug 13029] Permit NPAPI plug-ins to see HTTP response headers : [Attachment 14013] Proposed solution, take 6

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 11 17:57:29 PDT 2007


Deneb Meketa <dmeketa at adobe.com> has asked  for review:
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers
http://bugs.webkit.org/show_bug.cgi?id=13029

Attachment 14013: Proposed solution, take 6
http://bugs.webkit.org/attachment.cgi?id=14013&action=edit

------- Additional Comments from Deneb Meketa <dmeketa at adobe.com>
New patch that should be compatible with latest code from svn trunk. Changes
from last patch are:

- No longer need to add NPObject enumeration stubs, since this is now
implemented

- Dovetail with code related to NPObject enumeration in test plugin

- Deal with WebBaseNetscapePluginStream.m being renamed
WebBaseNetscapePluginStream.mm

- Fix a bug in my usage of snprintf in PluginObject.c

Otherwise it's the same code. Builds, loads pages, passes LayoutTests.
Hopefully review is short & sweet this time around, so this can get landed
before it rots again :)

Thanks.



More information about the webkit-reviews mailing list