[webkit-reviews] review granted: [Bug 13227] StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0) : [Attachment 13972] patch : 2-liner

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 15:54:51 PDT 2007


Darin Adler <darin at apple.com> has granted Jungshik Shin
<jungshik.shin at gmail.com>'s request for review:
Bug 13227: StringImpl::isLower incorrectly assumes islower returns 1 (it can
return any non-0)
http://bugs.webkit.org/show_bug.cgi?id=13227

Attachment 13972: patch : 2-liner
http://bugs.webkit.org/attachment.cgi?id=13972&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me; I think this might slow things down a bit; if so we might want to
implement our own islower instead.



More information about the webkit-reviews mailing list