[webkit-reviews] review requested: [Bug 13282] REGRESSION (NativePopUp): Right-most character cut-off in pop-up menu : [Attachment 13980] Make RenderMenuList draw the text directly, disabling rounding if necessary

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 09:08:27 PDT 2007


mitz at webkit.org has asked  for review:
Bug 13282: REGRESSION (NativePopUp): Right-most character cut-off in pop-up
menu
http://bugs.webkit.org/show_bug.cgi?id=13282

Attachment 13980: Make RenderMenuList draw the text directly, disabling
rounding if necessary
http://bugs.webkit.org/attachment.cgi?id=13980&action=edit

------- Additional Comments from mitz at webkit.org
This patch removes most of the RenderButton-derived code from RenderMenuList,
instead making it simply paint its own text. This gives it control over text
rounding, allowing it to match the platform's popup implementation.

I am not sure that a PopupMenu static will be sufficient for deciding what to
do (it's hard to tell currently). Maybe that part should be put off until it's
needed.



More information about the webkit-reviews mailing list