[webkit-reviews] review denied: [Bug 13291] REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse : [Attachment 13976] Move the call to didBeginEditing() back to Document::setFocusedNode()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 00:45:58 PDT 2007


Dave Hyatt <hyatt at apple.com> has denied mitz at webkit.org's request for review:
Bug 13291: REGRESSION (r19595): WebViewDidBeginEditingNotification not posted
when focusing with the mouse
http://bugs.webkit.org/show_bug.cgi?id=13291

Attachment 13976: Move the call to didBeginEditing() back to
Document::setFocusedNode()
http://bugs.webkit.org/attachment.cgi?id=13976&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I don't think the fix is that simple.  The problem I was originally fixing
involved the issue of being focused at a time when you don't yet have a
renderer.

I'm pretty sure in that case didBeginEditing is being called too early.  My
movement into updateFocusAppearance made didBeginEditing fire in places where
it was not before.  

(This is also why I expected results to change in the tests and I guess got
confused into thinking failures were changes for the better.)



More information about the webkit-reviews mailing list