[webkit-reviews] review requested: [Bug 13274] REGRESSION: Mouse events are not always sent to the "captured" subframe when dragging : [Attachment 13975] Build upon previous patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 23:06:56 PDT 2007


Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 13274: REGRESSION: Mouse events are not always sent to the "captured"
subframe when dragging
http://bugs.webkit.org/show_bug.cgi?id=13274

Attachment 13975: Build upon previous patch
http://bugs.webkit.org/attachment.cgi?id=13975&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This builds on the previous patch and also fixes the mouse move problem.

I also tweaked invalidateClick for the case where a widget toolkit does end up
going directly to a specific subframe so that m_mousePressed won't get "stuck"
but clears immediately as mouse down delivers events to subframes.

So now we basically have three kinds of capture: frame capture, widget capture
and node capture.  Frame and node capture are at least using a similar
cross-platform mechanism.  

Widget capture is basically buggy on the Mac now, but we've wallpapered over
the most obvious bugs by getting frame capture right.  Eventually Mac will
start sending events right to subviews, but in the mean time adding this extra
frame capture layer seems pretty straightforward and safe.



More information about the webkit-reviews mailing list