[webkit-reviews] review granted: [Bug 12959] REGRESSION: Edit -> Copy not enabled on standalone images : [Attachment 13906] Proposed patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 13:50:56 PDT 2007


Justin Garcia <justin.garcia at apple.com> has granted Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 12959: REGRESSION: Edit -> Copy not enabled on standalone images
http://bugs.webkit.org/show_bug.cgi?id=12959

Attachment 13906: Proposed patch 3
http://bugs.webkit.org/attachment.cgi?id=13906&action=edit

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
I think some code sharing between Pasteboard::writeImage(const HitTestResult&)
and writeImage(Node*, KURL) would have been possible, also you probably could
have created a public getter for ImageDocument's m_imageElement instead of
getting its body's first child, but r=me.



More information about the webkit-reviews mailing list