[webkit-reviews] review granted: [Bug 5262] XMLSerializer drops Namespace information : [Attachment 13953] patch for fix and test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 08:56:18 PDT 2007

Darin Adler <darin at apple.com> has granted Lamar Goddard
<lamargoddard at gmail.com>'s request for review:
Bug 5262: XMLSerializer drops Namespace information

Attachment 13953: patch for fix and test case

------- Additional Comments from Darin Adler <darin at apple.com>

There are three minor things wrong with this patch that are not serious enough
for a review-. One is that the change log for LayoutTests needs to list the
files modified, and in a couple cases instead it's listing the .xhtml files of
the tests with changed results.

Second, the explanation of nodeisequalnode14.xhtml failure is unnecessarily
confusing. It should say that it's supposed to create an Attr with localName of
null, which is the salient point I think.

The third problem is that we don't have nearly enough testing of the behavior
of createElementNS and getElementsByTagNameNS when passed a namespace of null
-- the new layout test is the only one that calls them that way, and it doesn't
test the behavior very thoroughly.

More information about the webkit-reviews mailing list