[webkit-reviews] review requested: [Bug 5262] XMLSerializer drops Namespace information : [Attachment 13953] patch for fix and test case

[bugzilla-daemon at webkit.org]

Lamar Goddard <lamargoddard at gmail.com> has asked  for review:
Bug 5262: XMLSerializer drops Namespace information
http://bugs.webkit.org/show_bug.cgi?id=5262

Attachment 13953: patch for fix and test case
http://bugs.webkit.org/attachment.cgi?id=13953&action=edit

------- Additional Comments from Lamar Goddard <lamargoddard at gmail.com>
I've added [ConvertNullToNullString] for the namespaceURI parameters in
Document's bindings of createAttributeNS, createElementNS and
getElementsByTagNameNS.

The dom/xhtml/level3/core/nodeisequal14.xhtml test now fails because an Attr
created from createAttribute is supposed to have a null prefix, localName and
namespaceURI.  See:
http://www.w3.org/TR/2004/REC-DOM-Level-3-Core-20040407/core.html#ID-1084891198

This was only passing before because the namespaceURI that was being used by
createAttributeNS(null, ...) was "null".

The dom/xhtml/level3/core/nodeisequal15.xhtml test now succeds as attributes
with no namespace from the page and attributes created explicitly with a
namespace of null have the same namespace.