[webkit-reviews] review denied: [Bug 5262] XMLSerializer drops Namespace information : [Attachment 13938] patch for fix and test case

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Lamar Goddard
<lamargoddard at gmail.com>'s request for review:
Bug 5262: XMLSerializer drops Namespace information
http://bugs.webkit.org/show_bug.cgi?id=5262

Attachment 13938: patch for fix and test case
http://bugs.webkit.org/attachment.cgi?id=13938&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch basically looks pretty good.

+    // Test _namespaceURI for "null" as null from js comes through as "null"

That's a bug that should be fixed at JavaScript binding call site. We shouldn't
convert a null to a string and then check for "null". Instead we should use
[ConvertNullToNullString] in the Document.idl file. Look at
DOMImplementation.idl for examples.

-			 markups.prepend(startMarkup(parent, range, annotate));

+			 markups.prepend(startMarkup(parent, range, annotate,
false, 0));

-			 markups.prepend(startMarkup(parent, range, annotate));

+			 markups.prepend(startMarkup(parent, range, annotate,
false, 0));

-		 markups.prepend(startMarkup(ancestor, range, annotate,
convertBlocksToInlines));
+		 markups.prepend(startMarkup(ancestor, range, annotate,
convertBlocksToInlines, 0));

-		 markups.prepend(startMarkup(ancestor, range, annotate));
+		 markups.prepend(startMarkup(ancestor, range, annotate, false,
0));

Why are these helpful changes? Those are the default values of those
parameters.