[webkit-reviews] review requested: [Bug 5262] XMLSerializer drops Namespace information : [Attachment 13938] patch for fix and test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 3 16:21:20 PDT 2007

Lamar Goddard <lamargoddard at gmail.com> has asked  for review:
Bug 5262: XMLSerializer drops Namespace information

Attachment 13938: patch for fix and test case

------- Additional Comments from Lamar Goddard <lamargoddard at gmail.com>
Fixed (4) by patching Document::createElementNS to use nullAtom if the
_namespaceURI param == "null" as createElementNS with a null namespace should
behave the same way as Document::createElement.  Didn't patch
JSImmediate::toString as it seems that other functions/tests assume that a null
from js will be converted to the string "null".  This issue may need to be
split out into its own bug as "null" and null are being treated the same by
Document::createElementNS and that shouldn't be.

I don't think (5) needs addressing (at least by this bug) as XMLSerializer only
calls createMarkup(Node* , ...).

More information about the webkit-reviews mailing list