[webkit-reviews] review granted: [Bug 13081] Empty table cells not handled correctly : [Attachment 13933] special handling for empty table cells

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 13081: Empty table cells not handled correctly
http://bugs.webkit.org/show_bug.cgi?id=13081

Attachment 13933: special handling for empty table cells
http://bugs.webkit.org/attachment.cgi?id=13933&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     if(!m_layoutStruct[lastCol].emptyCellsOnly)

Needs a space after the if.

	 case Static:
-	     numAuto++;
-	     totalAuto += m_layoutStruct[i].effMaxWidth;
-	     allocAuto += w;
+	     if (m_layoutStruct[i].emptyCellsOnly) 
+		 numAutoEmptyCellsOnly++;	     
+	     else {
+		 numAuto++;
+		 totalAuto += m_layoutStruct[i].effMaxWidth;
+		 allocAuto += w;
+	     }
	 default:
	     break;

It's pretty cheesy how this shares the break with the default case. I suggest
we remove the default altogether so we get the gcc warning about any missing
case values.

r=me