[webkit-reviews] review requested: [Bug 13081] Empty table cells not handled correctly : [Attachment 13933] special handling for empty table cells

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has asked  for review:
Bug 13081: Empty table cells not handled correctly
http://bugs.webkit.org/show_bug.cgi?id=13081

Attachment 13933: special handling for empty table cells
http://bugs.webkit.org/attachment.cgi?id=13933&action=edit

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
This behavior matches Firefox exactly (as far as the test case goes at least)
and is pretty close to IE7 too. The patch causes failures in result of tests
listed below. I went through the failures and they all seem to be meaningless,
not visible in rendering or progressions. For example pixel results of acid2 do
not change even though the render tree dump does.

New results for these would need to be checked in as well. Test
fast/css/percentage-non-integer relies on old empty cell behavior and would
need modifications to look nice again.

fast/block/positioning/negative-right-pos
fast/css/acid2-pixel	
fast/css/acid2
fast/css/percentage-non-integer
fast/repaint/table-cell-move
fast/table/012
fast/table/032
fast/table/empty-section-crash
http/tests/misc/acid2-pixel	
http/tests/misc/acid2	
tables/mozilla/bugs/bug1188	
tables/mozilla/bugs/bug1818-6	
tables/mozilla/bugs/bug16012
tables/mozilla/bugs/bug78162	
tables/mozilla/bugs/bug100334	
tables/mozilla/bugs/bug222336	
tables/mozilla/bugs/bug222467
tables/mozilla/core/misc
tables/mozilla_expected_failures/bugs/bug14007-1	
tables/mozilla_expected_failures/bugs/bug72393
tables/mozilla_expected_failures/other/empty_cells