[webkit-reviews] review granted: [Bug 13251] editing/style/fontsize-1.html fails intermittently when run multiple times on Intel, generates incorrect DOM : [Attachment 13914] Don't generate 'size' attribute for relative font sizes, and ASSERT on wildly illegal conversions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 2 07:59:38 PDT 2007


Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 13251: editing/style/fontsize-1.html fails intermittently when run multiple
times on Intel, generates incorrect DOM
http://bugs.webkit.org/show_bug.cgi?id=13251

Attachment 13914: Don't generate 'size' attribute for relative font sizes, and
ASSERT on wildly illegal conversions
http://bugs.webkit.org/attachment.cgi?id=13914&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd prefer not to have ad-hoc comparisons of the unit type with values. All the
< PX, > PC, <= CSS_DIMENSION is quite unclear and should be done with helper
inline functions instead.

But for this fix, r=me



More information about the webkit-reviews mailing list