[webkit-reviews] review granted: [Bug 11057] Auto-generate more SVG Objective-C bindings : [Attachment 10825] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 28 10:34:29 PDT 2006


Timothy Hatcher <timothy at hatcher.name> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 11057: Auto-generate more SVG Objective-C bindings
http://bugzilla.opendarwin.org/show_bug.cgi?id=11057

Attachment 10825: patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10825&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Why this change?

-	perl -I $(WebCore)/bindings/scripts
$(WebCore)/bindings/scripts/generate-bindings.pl --defines "$(FEATURE_DEFINES)
LANGUAGE_OBJECTIVE_C" --generator ObjC --include $(WebCore)/dom --include
$(WebCore)/html --include $(WebCore)/xpath --include $(WebCore)/ksvg2/svg
--outputdir . $<
+	perl -I $(WebCore)/bindings/scripts
$(WebCore)/bindings/scripts/generate-bindings.pl --defines "$(FEATURE_DEFINES)
LANGUAGE_OBJECTIVE_C" --generator ObjC --include dom --include html --include
xml --include /ksvg2/svg --outputdir . $<

There are other places hat do this, like the JS generator. I think passing the
full path is better.



More information about the webkit-reviews mailing list