[webkit-reviews] review denied: [Bug 10893] InsertRule can not handle @import statements : [Attachment 10822] Improved testcases

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 28 09:08:27 PDT 2006

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 10893: InsertRule can not handle @import statements

Attachment 10822: Improved testcases

------- Additional Comments from Darin Adler <darin at apple.com>
The bug fix looks great.

But I don't understand why css-insert-import-rule.html ignores exceptions.
Either it should expect an exception, and fail if the expected one doesn't
happen, or expect no exception, and fail if an exception occurs.

Hiding whether an exception happened or not is not a good choice for a test.

Another way to do the grammar is to have a non-terminal that's either a ruleset
or an import, then we would not have to repeat the assignment statement.

I'm going to review- just for the exception issue in the test, but this change
otherwise looks great!

More information about the webkit-reviews mailing list