[webkit-reviews] review requested: [Bug 4980] CSS2: Counters not supported : [Attachment 10821] Patch for Darin's most recent comments

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 28 02:14:25 PDT 2006


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 4980: CSS2: Counters not supported
http://bugzilla.opendarwin.org/show_bug.cgi?id=4980

Attachment 10821: Patch for Darin's most recent comments
http://bugzilla.opendarwin.org/attachment.cgi?id=10821&action=edit

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here is a patch that addresses nearly all of Darin's most recent comments. I
may have missed a few, but I will take a cleaner pass at it in the morning. One
thing I know for sure is that I haven't yet addressed any of the potential
overflow issues. I am hoping to talk with Darin about that in person since I am
not sure how best to deal with it. Also, instead of adding a HashMap to the
RenderView that keeps track of all of the objects and their CounterNodeMaps, I
made a static map in RenderObject. This seems more intuitive to me. Anywaym
here is what I got.



More information about the webkit-reviews mailing list