[webkit-reviews] review denied: [Bug 10893] InsertRule can not handle @import statements : [Attachment 10803] First attempt

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Sep 27 13:44:30 PDT 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 10893: InsertRule can not handle @import statements

Attachment 10803: First attempt

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
That test does not look sufficient.

I would suggest having a <div> which is colored red, when you insert the new
@import rule, it should link to a stylesheet with a more specific definition
for that div which turns it green.

Otherwise the patch looks fine.

More information about the webkit-reviews mailing list