[webkit-reviews] review granted: [Bug 11015] SVG handles em units incorrectly : [Attachment 10797] Improved patch

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 11015: SVG handles em units incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=11015

Attachment 10797: Improved patch
http://bugzilla.opendarwin.org/attachment.cgi?id=10797&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
No need for these extra { }:
+    {
+	 if (renderer())
+	     renderer()->setNeedsLayout(true);
+    }

+    SVGElement::attributeChanged(attr, preserveDecls);

should call the direct parent, not skip parents in the chain.  That will cause
weird bugs later (when we start to depend on SVGTransformableElement (or
similar) doing the proper attributeChanged actions.

Resolve those two issues and land away!

r=me