[webkit-reviews] review denied: [Bug 11015] SVG handles em units
incorrectly : [Attachment 10796] Now with testcases
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Wed Sep 27 03:40:48 PDT 2006
Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 11015: SVG handles em units incorrectly
http://bugzilla.opendarwin.org/show_bug.cgi?id=11015
Attachment 10796: Now with testcases
http://bugzilla.opendarwin.org/attachment.cgi?id=10796&action=edit
------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Hum... Did you test to see if each of these was needed?
if (attr->name() == SVGNames::xAttr) {
xBaseValue()->setValueAsString(value);
+ if (renderer())
+ renderer()->setNeedsLayout(true);
Also, that's the wrong place to put that. Those invalidations should go in
attributeChange(attributeName) instead of parseMappedAttribute
Otherwise the patch looks great!
More information about the webkit-reviews
mailing list